Skip to content

ref(tracing): Require to pass client to startBrowserTracing*Span utils#10410

Merged
mydea merged 2 commits intodevelopfrom
fn/browserTracingUtils
Jan 30, 2024
Merged

ref(tracing): Require to pass client to startBrowserTracing*Span utils#10410
mydea merged 2 commits intodevelopfrom
fn/browserTracingUtils

Conversation

@mydea
Copy link
Copy Markdown
Member

@mydea mydea commented Jan 30, 2024

So we can be client-safe when extending the integration.

@mydea mydea requested a review from lforst January 30, 2024 09:52
@mydea mydea self-assigned this Jan 30, 2024
@mydea mydea force-pushed the fn/browserTracingUtils branch from 00c36d3 to 9509458 Compare January 30, 2024 10:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.18 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.39 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.28 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.01 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.41 KB (+0.03% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.28 KB (+0.05% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (0%)
@sentry/browser - Webpack (gzipped) 22.6 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.54 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.44 KB (+0.12% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.66 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.09 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.11 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.98 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.56 KB (+0.11% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.78 KB (-0.02% 🔽)
@sentry/react - Webpack (gzipped) 22.63 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.45 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.76 KB (+0.01% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@mydea mydea changed the title feat(tracing): Allow to pass client to startBrowserTracing*Span utils ref(tracing): Require to pass client to startBrowserTracing*Span utils Jan 30, 2024
@mydea mydea enabled auto-merge (squash) January 30, 2024 11:01
@mydea mydea force-pushed the fn/browserTracingUtils branch from 9509458 to 4af9057 Compare January 30, 2024 11:05
@mydea mydea merged commit 2195ce6 into develop Jan 30, 2024
@mydea mydea deleted the fn/browserTracingUtils branch January 30, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea @lforst