Skip to content

fix(deno): Call function if client is not setup#10354

Merged
AbhiPrasad merged 1 commit intodevelopfrom
abhi-fix-deno-cron
Jan 25, 2024
Merged

fix(deno): Call function if client is not setup#10354
AbhiPrasad merged 1 commit intodevelopfrom
abhi-fix-deno-cron

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Contributor

I think this conditional needs to still call the deno cron fn(), and that we should do an early return if the client is not on SETUP_CLIENTS

@AbhiPrasad AbhiPrasad requested review from mydea and timfish January 25, 2024 20:28
Copy link
Copy Markdown
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn, good catch!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) January 25, 2024 20:44
@AbhiPrasad AbhiPrasad merged commit e0869ab into develop Jan 25, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-fix-deno-cron branch January 25, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants