Skip to content

test(node): Add mongoose auto instrumentation test for @sentry/node-experimental#10322

Merged
AbhiPrasad merged 1 commit intogetsentry:developfrom
timfish:test/otel-mongoose
Jan 24, 2024
Merged

test(node): Add mongoose auto instrumentation test for @sentry/node-experimental#10322
AbhiPrasad merged 1 commit intogetsentry:developfrom
timfish:test/otel-mongoose

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented Jan 24, 2024

This tests v5.13.22 of mongoose because it's the most commonly use version currently supported by the OpenTelemetry plugin:

https://github.com/open-telemetry/opentelemetry-js-contrib/blob/fce7d3b5e478ff7525c9ffe99e59bf35f8c06207/plugins/node/instrumentation-mongoose/src/mongoose.ts#L80

https://www.npmjs.com/package/mongoose?activeTab=versions

It's worth noting that at least versions 5 and 7 of mongoose also generate mongodb spans because they use the library internally and we auto instrument everything. For some unknown reason, mongoose@v8 does not appear to generate mongodb spans and I haven't tested v6 because very few people are using it.

@timfish timfish marked this pull request as ready for review January 24, 2024 17:27
@AbhiPrasad AbhiPrasad merged commit b146d4c into getsentry:develop Jan 24, 2024
@timfish timfish deleted the test/otel-mongoose branch January 24, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants