test(node): Add mysql2 auto instrumentation test for @sentry/node-experimental#10259
Merged
AbhiPrasad merged 5 commits intogetsentry:developfrom Jan 25, 2024
Merged
test(node): Add mysql2 auto instrumentation test for @sentry/node-experimental#10259AbhiPrasad merged 5 commits intogetsentry:developfrom
mysql2 auto instrumentation test for @sentry/node-experimental#10259AbhiPrasad merged 5 commits intogetsentry:developfrom
Conversation
mydea
approved these changes
Jan 19, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
Is there a way to auto clean the docker stuff? Or at least to add it to yarn clean for node-integration-tests to remove all of the ones we added, or something like this? 🤔
Collaborator
Author
|
|
AbhiPrasad
approved these changes
Jan 24, 2024
mydea
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test for
mysql2auto instrumentation for@sentry/node-experimental.mysql2will not query unless there is a connection and it does not want to work without one likemysql.This PR adds a
withDockerComposemethod to the test runner which handles:My only minor concern is that the mysql docker container creates a volume to store data. If the cleanup code does not run, a 180MB volume is left behind after every run. This will only be an issue when testing locally but we could start to fill developers machines. These can be cleaned up via
docker volume prune --forcebut I would not want to run this on peoples machines without telling them!