fix(tracing): Gate mongo operation span data behind sendDefaultPii#10227
Merged
AbhiPrasad merged 3 commits intodevelopfrom Jan 18, 2024
Merged
fix(tracing): Gate mongo operation span data behind sendDefaultPii#10227AbhiPrasad merged 3 commits intodevelopfrom
AbhiPrasad merged 3 commits intodevelopfrom
Conversation
timfish
approved these changes
Jan 17, 2024
Contributor
size-limit report 📦
|
mydea
approved these changes
Jan 18, 2024
08f3e00 to
3592dbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was raised in #10219, we set some extra operation based fields on span data for mongodb.
This is unfortunately just serialized output, which means it can contain PII (it needs to be paramaterized for PII to be removed).
Given this data will change a lot when we switch to OTEL, gate setting this specific span data behind
sendDefaultPii.