feat(core): Deprecate hub.bindClient() & makeMain()#10188
Merged
Conversation
Instead, users should use `setCurrentClient()` & `client.init()`.
Contributor
size-limit report 📦
|
lforst
approved these changes
Jan 16, 2024
Contributor
lforst
left a comment
There was a problem hiding this comment.
Not a fan of setCurrentClient but it's where we're at.
lforst
approved these changes
Jan 16, 2024
Contributor
lforst
left a comment
There was a problem hiding this comment.
Not a fan of setCurrentClient but it's where we're at.
2 tasks
Lms24
approved these changes
Jan 16, 2024
| gzip: false, | ||
| brotli: false, | ||
| limit: '100 KB', | ||
| limit: '105 KB', |
Member
There was a problem hiding this comment.
side note (no action required): I really hope that our bundle size will decrease to ~v7.0.0 levels once we removed all the deprecated stuff
Member
Author
There was a problem hiding this comment.
yeah, it will decrease for sure - right now we need to add a certain degree of duplication, sadly, which will go away again! I'm very optimistic in this regard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, users should use
setCurrentClient()&client.init().For now, we can't fully replace our own test usages of this everywhere, as we need it to test a clean hub state. But for users, there should be a reasonable path forward for 99% of cases. I added a docs page outlining how the different scenarios will work in v8 (and already should work now, too).