ref(nextjs): Remove internal deprecated usage of deepReadDirSync#10129
Merged
ref(nextjs): Remove internal deprecated usage of deepReadDirSync#10129
deepReadDirSync#10129Conversation
deepReadDirSyncdeepReadDirSync
Lms24
approved these changes
Jan 10, 2024
Member
Lms24
left a comment
There was a problem hiding this comment.
I guess the replacement for these tests are our e2e tests, correct?
84ebf9f to
4f7d371
Compare
Contributor
Author
Originally we added these tests to ensure the Sentry CLI binary will not be included in AWS lambdas when deploying nextjs to vercel. We now have this test inside the CLI repository itself. |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes usage of
deepReadDirSyncby removing the unused tests that call it.Ref: #10100