Merged
Conversation
added 2 commits
January 4, 2024 09:37
mydea
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into some funky behaviour where I had to run the
lintscript multiple times in order for all lint errors to be printed to me in the terminal.Then I realized this mistake in our Nx config that we hadn't referenced the
lintscript but thelint:eslintscript which doesn't exist.I think this got introduced in 5658aff
Additionally, lint technically depends on
build:typesof the parent package, and in some cases even in the own package (Next.js), so I added that to the nx config.Also, we were not marking the right outputs of build, so we're fixing that.