Conversation
Contributor
size-limit report 📦
|
3ce59d8 to
25027f9
Compare
AbhiPrasad
approved these changes
Jan 5, 2024
Lms24
reviewed
Jan 8, 2024
Comment on lines
+70
to
+110
| export function spanIsSampled(span: Span): boolean { | ||
| const { traceFlags } = span.spanContext(); | ||
| // eslint-disable-next-line no-bitwise | ||
| return Boolean(traceFlags & TraceFlagSampled); | ||
| } |
Member
There was a problem hiding this comment.
Can we add a reference to OTel for this bit operation? I assume there's some documentation around the bit fields or masks?
Member
Author
There was a problem hiding this comment.
Yeah, I'll reference where this comes from 😅
packages/core/src/utils/spanUtils.ts
Outdated
Comment on lines
+4
to
+6
| export const TraceFlagNone = 0x0; | ||
| // eslint-disable-next-line no-bitwise | ||
| export const TraceFlagSampled = 0x1 << 0; |
Member
Author
There was a problem hiding this comment.
good point, makes more sense!
Member
Author
There was a problem hiding this comment.
Yeah, I think so, I copied this from OTEL, not sure why they have this weird syntax - it is the same, right? 🤔
Member
There was a problem hiding this comment.
I think so. Maybe they do it just for clarity?
0x1 << 0 // sampled flag
0x1 << 1 // another flagbut yes, it's identical
> 0x1 === 0x1 << 0
true
Member
Author
There was a problem hiding this comment.
I updated it and added a comment that this is aligned to how this is in OTEL!
Lms24
approved these changes
Jan 8, 2024
|
I get this error after upgrading |
Member
Author
|
@mustafa0x can you make sure you have no |
|
@mydea deleting node_modules and pnpm-lock.yaml did indeed fix! In pnpm-lock.yaml I noticed Thanks! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will replace
spanId,traceIdandsampledlookups.Because the bitwise format of OTEL is a bit weird IMHO to check if a span is sampled, I also added a utility
spanIsSampled(span)method to abstract this away.