-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
Description
Flakiness Type
Other / Unknown
Name of Job
Install Dependencies
Name of Test
N/A
Link to Test Run
https://github.com/getsentry/sentry-javascript/actions/runs/5445228367/jobs/9904174554?pr=8438
Details
I was just checking out your CI configuration to get inspiration for how to rework the CI at Ghost, and I noticed that cache-hit has been typo'd as cache_hit here:
sentry-javascript/.github/workflows/build.yml
Line 182 in 16a29c0
| if: steps.cache_dependencies.outputs.cache_hit != 'true' |
https://github.com/actions/cache#outputs names cache-hit as the value
As a result, the yarn command is always executed, even if the cache was hit, which burns quite a bit of CI time
In the linked test run (just a random PR on your repo), you can see the cache was hit but we still executed the yarn
🙂
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
Waiting for: Product Owner