Skip to content

https.request is broken by agent-base included by https-proxy-agent #2085

@davidnikdel-epic

Description

@davidnikdel-epic

Package + Version

  • @sentry/node

Version:

4.6.6
5.3.0

Description

Some time after 4.1.1 sentry started depending on https-proxy-agent. https-proxy-agent depends on agent-base which does a little nasty thing where it patches over node-core's https.request here

Problems are:

  1. this patch only supports the 2 parameter form.
  2. this patch does not support any forms where a URL object is passed in (instead of the string) due to its reliance on Object.assign

Docs on node's https.request

Unfortunately this means any app that depends on @sentry/node also receives this lovely bug.

Metadata

Metadata

Assignees

Labels

No labels
No labels
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions