Send file name and path only if isSendDefaultPii is true#3919
Merged
stefanosiano merged 3 commits into8.x.xfrom Nov 21, 2024
Merged
Send file name and path only if isSendDefaultPii is true#3919stefanosiano merged 3 commits into8.x.xfrom
stefanosiano merged 3 commits into8.x.xfrom
Conversation
file path on Android is sent only if isSendDefaultPii is true
Contributor
Performance metrics 🚀
|
adinauer
approved these changes
Nov 21, 2024
Member
adinauer
left a comment
There was a problem hiding this comment.
Mostly LGTM, we should probably use our util for getting the file extension.
sentry/src/main/java/io/sentry/instrumentation/file/FileIOSpanManager.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
file span description is now masked if isSendDefaultPii is false
file path on Android is sent only if isSendDefaultPii is true
💡 Motivation and Context
Closes #3324
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps