Skip to content

Mark hint flushed when rate limited#3892

Merged
adinauer merged 6 commits into8.x.xfrom
feat/mark-flushed-when-rate-limited
Nov 21, 2024
Merged

Mark hint flushed when rate limited#3892
adinauer merged 6 commits into8.x.xfrom
feat/mark-flushed-when-rate-limited

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Nov 15, 2024

📜 Description

  • UncaughtExceptionHandlerIntegration.uncaughtException waits the full 15s after capturing an event and calling hint.waitFlush() when rate limited since we never called markFlushed in RateLimiter.

💡 Motivation and Context

Fixes #3857

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f232023

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 415.50 ms 498.47 ms 82.97 ms
Size 1.65 MiB 2.31 MiB 673.62 KiB

Previous results on branch: feat/mark-flushed-when-rate-limited

Startup times

Revision Plain With Sentry Diff
d0d4f5b 392.53 ms 412.38 ms 19.85 ms
2766c4a 389.74 ms 427.91 ms 38.17 ms
22fd90d 451.64 ms 459.98 ms 8.34 ms

App size

Revision Plain With Sentry Diff
d0d4f5b 1.65 MiB 2.31 MiB 673.75 KiB
2766c4a 1.65 MiB 2.31 MiB 673.75 KiB
22fd90d 1.65 MiB 2.31 MiB 673.62 KiB

lbloder
lbloder approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

romtsn
romtsn reviewed Nov 20, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited by adinauer
Loading

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited by adinauer
Loading

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

@adinauer adinauer merged commit 159a367 into 8.x.x Nov 21, 2024
@adinauer adinauer deleted the feat/mark-flushed-when-rate-limited branch November 21, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romtsn romtsn romtsn approved these changes

@lbloder lbloder lbloder approved these changes

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adinauer @romtsn @lbloder