Skip to content

Apollo v2 BeforeSpanCallback: Allow returning null#2890

Merged
markushi merged 2 commits intofeat/7.0.0from
feat/apollo-v2-beforespancallback-nullable
Aug 8, 2023
Merged

Apollo v2 BeforeSpanCallback: Allow returning null#2890
markushi merged 2 commits intofeat/7.0.0from
feat/apollo-v2-beforespancallback-nullable

Conversation

@markushi
Copy link
Member

@markushi markushi commented Aug 8, 2023 •
edited
Loading

📜 Description

Adds nullability to BeforeSpanCallback callback

💡 Motivation and Context

Fixes #2149

💚 How did you test it?

Added unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 311.14 ms 351.46 ms 40.32 ms
Size 1.72 MiB 2.29 MiB 576.28 KiB

@codecov
Copy link

codecov bot commented Aug 8, 2023 •
edited
Loading

Codecov Report

Patch coverage: 87.43% and project coverage change: +0.19% 🎉

Comparison is base (9020d1b) 81.26% compared to head (a723174) 81.45%.
Report is 43 commits behind head on feat/7.0.0.

Additional details and impacted files 
@@               Coverage Diff                @@
##             feat/7.0.0    #2890      +/-   ##
================================================
+ Coverage         81.26%   81.45%   +0.19%     
- Complexity         4560     4661     +101     
================================================
  Files               350      354       +4     
  Lines             16866    17155     +289     
  Branches           2272     2321      +49     
================================================
+ Hits              13706    13974     +268     
- Misses             2219     2231      +12     
- Partials            941      950       +9
Files Changed Coverage Δ
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (ø)
...ebflux/SentryWebFilterWithThreadLocalAccessor.java 0.00% <0.00%> (ø)
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (ø)
sentry/src/main/java/io/sentry/Breadcrumb.java 85.04% <ø> (ø)
sentry/src/main/java/io/sentry/HostnameCache.java 90.69% <ø> (ø)
sentry/src/main/java/io/sentry/Hub.java 75.17% <ø> (ø)
.../src/main/java/io/sentry/JsonObjectSerializer.java 84.21% <ø> (ø)
...ry/src/main/java/io/sentry/ProfilingTraceData.java 78.51% <ø> (ø)
.../main/java/io/sentry/ProfilingTransactionData.java 52.52% <ø> (ø)
sentry/src/main/java/io/sentry/Scope.java 96.72% <0.00%> (-0.36%) ⬇️
... and 83 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markushi markushi merged commit ee21d53 into feat/7.0.0 Aug 8, 2023
@markushi markushi deleted the feat/apollo-v2-beforespancallback-nullable branch August 8, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romtsn romtsn romtsn approved these changes

@adinauer adinauer Awaiting requested review from adinauer

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markushi @romtsn