Switch to compileOnly dependencies in sentry-compose#2578
Merged
Conversation
4 tasks
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| db5bd4e | 352.90 ms | 359.52 ms | 6.62 ms |
| d691d8f | 352.56 ms | 389.59 ms | 37.03 ms |
| db5bd4e | 314.82 ms | 349.17 ms | 34.35 ms |
| db5bd4e | 347.00 ms | 366.74 ms | 19.74 ms |
| db5bd4e | 286.94 ms | 315.26 ms | 28.32 ms |
| e5bbb00 | 317.46 ms | 353.26 ms | 35.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| db5bd4e | 1.73 MiB | 2.34 MiB | 626.30 KiB |
| d691d8f | 1.73 MiB | 2.34 MiB | 626.23 KiB |
| db5bd4e | 1.73 MiB | 2.34 MiB | 626.30 KiB |
| db5bd4e | 1.73 MiB | 2.34 MiB | 626.30 KiB |
| db5bd4e | 1.73 MiB | 2.34 MiB | 626.30 KiB |
| e5bbb00 | 1.73 MiB | 2.34 MiB | 626.22 KiB |
This was referenced Mar 1, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2578 +/- ##
=========================================
Coverage 80.44% 80.44%
Complexity 4020 4020
=========================================
Files 332 332
Lines 15160 15160
Branches 1979 1979
=========================================
Hits 12195 12195
Misses 2186 2186
Partials 779 779
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
markushi
approved these changes
Mar 2, 2023
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Switch to compileOnly dependencies in sentry-compose ([#2578](https://github.com/getsentry/sentry-java/pull/2578))If none of the above apply, you can opt out of this check by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Since our Gradle Plugin is modifying the
.pomof the dependencies to auto-install integrations, sentry-compose itself was depending onandroidx.compose:runtime, therefore after auto-installing it was creating a circular dependency. This PR fixes that, so the users will have to have compose/compose-navigation on their classpath for our integration to kick in.It's also fine if they don't have them on the classpath, because our Navigation instrumentation will not be called/installed if there's no
NavHostControlleron the classpath.Similar to #2175
💡 Motivation and Context
Closes #2364
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
2 more PRs: