Skip to content

Replace ThreadLocal in Sentry with HubStorage and a wrapped ThreadLoc…#2224

Closed
adinauer wants to merge 2 commits intomainfrom
feat/hackweek-threadlocal-webflux
Closed

Replace ThreadLocal in Sentry with HubStorage and a wrapped ThreadLoc…#2224
adinauer wants to merge 2 commits intomainfrom
feat/hackweek-threadlocal-webflux

Conversation

@adinauer
Copy link
Copy Markdown
Member

…al Hub; also fix Webflux integration and add transaction support for webflux

📜 Description

Hackweek project 2022

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

  • More testing
  • Fix tests
  • Cleanup code

…al Hub; also fix Webflux integration and add transaction support for webflux
@adinauer adinauer requested a review from romtsn as a code owner August 26, 2022 10:47
@adinauer adinauer marked this pull request as draft August 26, 2022 10:47
@github-actions
Copy link
Copy Markdown
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Replace ThreadLocal in Sentry with HubStorage and a wrapped ThreadLoc… ([#2224](https://github.com/getsentry/sentry-java/pull/2224))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 8ad9b37

@alphec
Copy link
Copy Markdown

alphec commented Oct 11, 2022

Sorry for commenting on this issue specifically, but there is no clear place where this comment should go.

I wonder what the current state of error reporting and automatic transaction capturing with Spring WebFlux is - especially with the Sentry client 6.5.0. I see a couple of PRs that seem related to these issues. I wonder if there is a plan to move forward and maybe areas where help is needed.

@adinauer
Copy link
Copy Markdown
Member Author

adinauer commented Feb 24, 2023

Closing this in favor of #2546

@adinauer adinauer closed this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants