Merged
Conversation
27 tasks
Codecov Report
@@ Coverage Diff @@
## main #1188 +/- ##
============================================
- Coverage 74.70% 74.64% -0.07%
- Complexity 1662 1670 +8
============================================
Files 174 176 +2
Lines 5851 5872 +21
Branches 572 572
============================================
+ Hits 4371 4383 +12
- Misses 1216 1225 +9
Partials 264 264
Continue to review full report at Codecov.
|
Contributor
don't make Wars make Jars cc @bruno-garcia haha |
marandaneto
reviewed
Jan 21, 2021
sentry-spring/src/main/java/io/sentry/spring/SentrySpringServletContainerInitializer.java
Outdated
Show resolved
Hide resolved
marandaneto
approved these changes
Jan 21, 2021
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Simplify using Sentry error reporting and Sentry Performance feature in Spring (non-boot) integration. Also, change the sample project for Spring integration into traditional WAR application.
💡 Motivation and Context
Sentry Spring integration was working well with embedded servlet containers scenarios but appeared to be difficult to configure when used in traditional WAR deployment.
Also, fixed: #1187
💚 How did you test it?
Unit & Integration tests.
📝 Checklist
🔮 Next steps
Since there is a method
IHub#getOptionsthere is a potential to move some bits ofsentry-springtosentry-servlet.