Merged
Conversation
maciejwalkowiak
commented
Jan 14, 2021
22 tasks
marandaneto
reviewed
Jan 14, 2021
marandaneto
reviewed
Jan 14, 2021
marandaneto
reviewed
Jan 14, 2021
marandaneto
reviewed
Jan 14, 2021
Codecov Report
@@ Coverage Diff @@
## main #1165 +/- ##
============================================
- Coverage 74.94% 74.73% -0.22%
+ Complexity 1663 1661 -2
============================================
Files 173 174 +1
Lines 5832 5850 +18
Branches 571 571
============================================
+ Hits 4371 4372 +1
- Misses 1199 1215 +16
- Partials 262 263 +1
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Jan 16, 2021
marandaneto
reviewed
Jan 18, 2021
marandaneto
reviewed
Jan 18, 2021
marandaneto
reviewed
Jan 18, 2021
Contributor
|
to not forget: getsentry/sentry-docs#2912 |
marandaneto
reviewed
Jan 18, 2021
...ry-spring/src/main/java/io/sentry/spring/tracing/SentrySpanClientHttpRequestInterceptor.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Jan 18, 2021
rhcarvalho
reviewed
Jan 18, 2021
Contributor
Author
|
@bruno-garcia @marandaneto all polishing applied, please have another look. |
marandaneto
reviewed
Jan 19, 2021
marandaneto
reviewed
Jan 19, 2021
marandaneto
reviewed
Jan 19, 2021
marandaneto
reviewed
Jan 19, 2021
marandaneto
reviewed
Jan 19, 2021
Contributor
|
I thought this PR was already Polish 🇵🇱 |
Member
Never gets old :D 🇵🇱 🇲🇨 🇵🇱 🇲🇨 🇵🇱 🇲🇨 🇵🇱 🇲🇨 |
marandaneto
reviewed
Jan 20, 2021
| return startChild(); | ||
| public @NotNull ISpan startChild( | ||
| final @NotNull String operation, final @Nullable String description) { | ||
| return startChild(operation); |
Contributor
There was a problem hiding this comment.
just a nit: you could return NoOpSpan.getInstance(); directly so you spare a method call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish Performance related API as a result of a call with @marandaneto @Tyrrrz.