Feat: OutboxSender supports all envelope item types#1158
Merged
marandaneto merged 7 commits intomainfrom Jan 14, 2021
Merged
Conversation
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
LGTM so far, just needing tests or there's something else?
Contributor
Author
runtime tests and unit tests, but looks straightforward, will finish today |
Codecov Report
@@ Coverage Diff @@
## main #1158 +/- ##
============================================
- Coverage 75.25% 75.22% -0.04%
- Complexity 1661 1663 +2
============================================
Files 173 173
Lines 5808 5820 +12
Branches 568 569 +1
============================================
+ Hits 4371 4378 +7
- Misses 1173 1177 +4
- Partials 264 265 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Feat: OutboxSender supports all envelope item types
💡 Motivation and Context
#1157 and #1103
💚 How did you test it?
📝 Checklist
🔮 Next steps