Fix: Set release and environment on Transactions.#1152
Merged
maciejwalkowiak merged 3 commits intomainfrom Jan 7, 2021
Merged
Conversation
22 tasks
Codecov Report
@@ Coverage Diff @@
## main #1152 +/- ##
============================================
+ Coverage 75.22% 75.25% +0.02%
- Complexity 1630 1633 +3
============================================
Files 168 168
Lines 5639 5645 +6
Branches 554 555 +1
============================================
+ Hits 4242 4248 +6
Misses 1144 1144
Partials 253 253
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Jan 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Set release and environment on Transactions.
💡 Motivation and Context
Fixes #1147
Both release and environment have to be set on transactions independently from how they are set on SentryEvents since transactions are not a subject of event processing.
💚 How did you test it?
📝 Checklist