Skip to content

Make Access Modifier For Transaction.UpdateStartDate Public  #3639

@sentryadam0000345

Description

@sentryadam0000345

Problem Statement

In some rare cases we aren't ready to use sentry yet but would like to start a trace. Updating end date is enough right now, can still construct whatever length we want though it would be nice to be able to set the start/end to the actual times something happened.

Specifically, this is in regards to overriding the duration value of an event. In particular, overriding the duration value for a custom Performance Span.

Solution Brainstorm

It seems like the change here should be fairly easy. Just change the access modifier to public from private like it is set for updateEndDate.

Here are the relevant lines in the SDK that I found that would need to be looked at/changed:

public boolean updateEndDate(final @NotNull SentryDate date) {

private void updateStartDate(@NotNull SentryDate date) {

┆Issue is synchronized with this Jira Improvement by Unito

Metadata

Metadata

Assignees

Labels

No labels
No labels
No fields configured for issues without a type.

Projects

Status

No status

Relationships

None yet

Development

No branches or pull requests

Issue actions