Add tests for main hub cloning

adinauer · adinauer · commit e132c76aa589 · 2023-03-01T09:22:22.000+01:00
diff --git a/sentry/src/test/java/io/sentry/SentryTest.kt b/sentry/src/test/java/io/sentry/SentryTest.kt
@@ -22,6 +22,7 @@ import kotlin.test.Test
 import kotlin.test.assertEquals
 import kotlin.test.assertFalse
 import kotlin.test.assertNotNull
+import kotlin.test.assertNull
 import kotlin.test.assertTrue
 
 class SentryTest {
@@ -241,6 +242,108 @@ class SentryTest {
         assertFalse(hub is NoOpHub)
     }
 
+    @Test
+    fun `main hub can be cloned and does not share scope with current hub`() {
+        // noop as not yet initialized, caches NoOpHub in ThreadLocal
+        Sentry.addBreadcrumb("breadcrumbNoOp")
+        Sentry.captureMessage("messageNoOp")
+
+        assertTrue(Sentry.getCurrentHub() is NoOpHub)
+
+        val capturedEvents = mutableListOf<SentryEvent>()
+
+        // init Sentry in another thread
+        val thread = Thread() {
+            Sentry.init {
+                it.dsn = dsn
+                it.isDebug = true
+                it.beforeSend = SentryOptions.BeforeSendCallback { event, hint ->
+                    capturedEvents.add(event)
+                    event
+                }
+            }
+        }
+        thread.start()
+        thread.join()
+
+        Sentry.addBreadcrumb("breadcrumbCurrent")
+
+        val hub = Sentry.getCurrentHub()
+        assertNotNull(hub)
+        assertFalse(hub is NoOpHub)
+
+        val newMainHubClone = Sentry.cloneMainHub()
+        newMainHubClone.addBreadcrumb("breadcrumbMainClone")
+
+        hub.captureMessage("messageCurrent")
+        newMainHubClone.captureMessage("messageMainClone")
+
+        assertEquals(2, capturedEvents.size)
+        val mainCloneEvent = capturedEvents.firstOrNull { it.message?.formatted == "messageMainClone" }
+        val currentHubEvent = capturedEvents.firstOrNull { it.message?.formatted == "messageCurrent" }
+
+        assertNotNull(mainCloneEvent)
+        assertNotNull(mainCloneEvent.breadcrumbs?.firstOrNull { it.message == "breadcrumbMainClone" })
+        assertNull(mainCloneEvent.breadcrumbs?.firstOrNull { it.message == "breadcrumbCurrent" })
+        assertNull(mainCloneEvent.breadcrumbs?.firstOrNull { it.message == "breadcrumbNoOp" })
+
+        assertNotNull(currentHubEvent)
+        assertNull(currentHubEvent.breadcrumbs?.firstOrNull { it.message == "breadcrumbMainClone" })
+        assertNotNull(currentHubEvent.breadcrumbs?.firstOrNull { it.message == "breadcrumbCurrent" })
+        assertNull(currentHubEvent.breadcrumbs?.firstOrNull { it.message == "breadcrumbNoOp" })
+    }
+
+    @Test
+    fun `main hub is not cloned in global hub mode and shares scope with current hub`() {
+        // noop as not yet initialized, caches NoOpHub in ThreadLocal
+        Sentry.addBreadcrumb("breadcrumbNoOp")
+        Sentry.captureMessage("messageNoOp")
+
+        assertTrue(Sentry.getCurrentHub() is NoOpHub)
+
+        val capturedEvents = mutableListOf<SentryEvent>()
+
+        // init Sentry in another thread
+        val thread = Thread() {
+            Sentry.init({
+                it.dsn = dsn
+                it.isDebug = true
+                it.beforeSend = SentryOptions.BeforeSendCallback { event, hint ->
+                    capturedEvents.add(event)
+                    event
+                }
+            }, true)
+        }
+        thread.start()
+        thread.join()
+
+        Sentry.addBreadcrumb("breadcrumbCurrent")
+
+        val hub = Sentry.getCurrentHub()
+        assertNotNull(hub)
+        assertFalse(hub is NoOpHub)
+
+        val newMainHubClone = Sentry.cloneMainHub()
+        newMainHubClone.addBreadcrumb("breadcrumbMainClone")
+
+        hub.captureMessage("messageCurrent")
+        newMainHubClone.captureMessage("messageMainClone")
+
+        assertEquals(2, capturedEvents.size)
+        val mainCloneEvent = capturedEvents.firstOrNull { it.message?.formatted == "messageMainClone" }
+        val currentHubEvent = capturedEvents.firstOrNull { it.message?.formatted == "messageCurrent" }
+
+        assertNotNull(mainCloneEvent)
+        assertNotNull(mainCloneEvent.breadcrumbs?.firstOrNull { it.message == "breadcrumbMainClone" })
+        assertNotNull(mainCloneEvent.breadcrumbs?.firstOrNull { it.message == "breadcrumbCurrent" })
+        assertNull(mainCloneEvent.breadcrumbs?.firstOrNull { it.message == "breadcrumbNoOp" })
+
+        assertNotNull(currentHubEvent)
+        assertNotNull(currentHubEvent.breadcrumbs?.firstOrNull { it.message == "breadcrumbMainClone" })
+        assertNotNull(currentHubEvent.breadcrumbs?.firstOrNull { it.message == "breadcrumbCurrent" })
+        assertNull(currentHubEvent.breadcrumbs?.firstOrNull { it.message == "breadcrumbNoOp" })
+    }
+
     @Test
     fun `when init is called and configure throws an exception then an error is logged`() {
         val logger = mock<ILogger>()
