Conversation
This was referenced Jan 30, 2023
This was referenced Jan 30, 2023
cleptric
commented
Jan 30, 2023
cleptric
commented
Jan 31, 2023
| // | ||
| // https://opentelemetry.io/docs/reference/specification/context/api-propagators/#inject | ||
| func (p sentryPropagator) Inject(ctx context.Context, carrier propagation.TextMapCarrier) { | ||
| sentry.Logger.Printf("\n--- Propagator Inject\nContext: %#v\nCarrier: %#v\n", ctx, carrier) |
Member
Author
There was a problem hiding this comment.
This might be super noisy for users. I use Debug: true a lot, so maybe we could reduce the output a little bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two main integration components (along with all the main supporting functions to enrich Sentry spans with OTel data):
Main discussion: getsentry/sentry#40712
Closes #526, closes #486.
A list of open issues with the implementation:
[OTel] Dynamic Sampling Context propagation does not work for nested spans #553
[OTel] Baggage parsed incorrectly if it contains encoded whitespaces ("%20") #554
otel/event_processor.go), but there's a caveat: the EventHint of the event processor has to contain a validContextwith a set OpenTelemetry span. This means that e.g. messages captured withsentry.CaptureMessageorhub.CaptureMessagewon't be linked to Sentry spans at the moment.[OTel] Expose context-aware methods for capturing events in public API #555
[OTel] Add "instrumenter" configuration option #556
[OTel] Improve HTTP Span attributes in SpanProcessor #557