Skip to content

Add integration with buffalo#196

Closed
stnguyen90 wants to merge 2 commits intogetsentry:masterfrom
stnguyen90:buffalo-integration
Closed

Add integration with buffalo#196
stnguyen90 wants to merge 2 commits intogetsentry:masterfrom
stnguyen90:buffalo-integration

Conversation

@stnguyen90
Copy link
Copy Markdown

fixes #194

@rhcarvalho rhcarvalho marked this pull request as draft April 9, 2020 08:17
@rhcarvalho rhcarvalho self-assigned this Apr 9, 2020
@stnguyen90 stnguyen90 marked this pull request as ready for review April 13, 2020 21:53
Copy link
Copy Markdown
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the Travis builds https://github.com/getsentry/sentry-go/pull/196/checks?check_run_id=572336394

The current code doesn't compile.

@rhcarvalho
Copy link
Copy Markdown
Contributor

Adding this will pull in a good bunch of new deps into go.mod, which is unfortunate.

Would be good to advance on #156 before, so that we don't bloat users' go.mod when they don't need the integration.

Alternatively, I'm also tracking golang/go#36460 which might alleviate the problem and allow us to have a single module == easier maintenance and distribution/consumption -- single coherent version. That's planned for Go 1.15.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2022

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an Integration for Buffalo Web Framework

3 participants