ref(grpc): Eliminate duplicate span status logic in finishSpan

cursoragent · claude · cursoragent · commit 9fd99bf004bc · 2026-04-20T08:57:11.000Z
Refactored finishSpan to call setRPCStatus internally instead of
duplicating the same three lines (grpcStatusCode, toSpanStatus,
SetData). This avoids maintaining identical status-setting logic
in two places and ensures consistency if the logic needs to change.

Co-Authored-By: Claude Sonnet 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/grpc/client.go b/grpc/client.go
@@ -48,9 +48,7 @@ func createOrUpdateMetadata(ctx context.Context, span *sentry.Span) context.Cont
 }
 
 func finishSpan(span *sentry.Span, err error) {
-	code := grpcStatusCode(err)
-	span.Status = toSpanStatus(code)
-	span.SetData("rpc.grpc.status_code", int(code))
+	setRPCStatus(span, err)
 	span.Finish()
 }
 

Original file line number	Diff line number	Diff line change
`@@ -48,9 +48,7 @@ func createOrUpdateMetadata(ctx context.Context, span *sentry.Span) context.Cont`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`func finishSpan(span *sentry.Span, err error) {`
`51`		`- code := grpcStatusCode(err)`
`52`		`- span.Status = toSpanStatus(code)`
`53`		`- span.SetData("rpc.grpc.status_code", int(code))`
	`51`	`+ setRPCStatus(span, err)`
`54`	`52`	`span.Finish()`
`55`	`53`	`}`
`56`	`54`