fix: Dispatch correctly for bundlers like webpack#84
Merged
Conversation
jan-auer
commented
May 14, 2018
| const frontendClass: FrontendClass<CommonFrontend, ElectronOptions> = | ||
| process.type === 'browser' | ||
| ? require('./main').MainFrontend | ||
| ? module.require('./main').MainFrontend |
Member
Author
There was a problem hiding this comment.
This is the actual fix, the rest is just an updated example.
timfish
approved these changes
May 14, 2018
Member
Author
|
This is ready now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend bundlers like webpack and rollup will statically resolve all
requires, which might break the build or switch to the main process implementation in renderers. This PR should fix this by usingmodule.requirefor importing the main implementation, which bypasses static bundlers entirely.The updated example also verifies that sandbox mode works. Next step would be to update tests to use
sandbox: trueand then remove the disclaimer from docs and add a guide on how to use the SDK in sandbox mode properly, instead.This diff is rather large, see the comment below for the relevant section. There should be sufficient code documentation above that statement explaining the reasoning behind this approach.
See #81 for more information.