Skip to content

fix: Normalize filename before parsing module name#699

Merged
timfish merged 2 commits intogetsentry:masterfrom
timfish:fix/normalise-module
Jul 13, 2023
Merged

fix: Normalize filename before parsing module name#699
timfish merged 2 commits intogetsentry:masterfrom
timfish:fix/normalise-module

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented Jul 13, 2023

Closes #686

This PR:

  • Updates to v7.58.0 of the JavaScript SDKs
  • Overrides the stack parser in the main process
    • Normalises the filename before parsing the module name
  • Adds a test to ensure module in the stack frame is correctly set

@timfish timfish marked this pull request as ready for review July 13, 2023 13:58
@timfish timfish requested a review from AbhiPrasad July 13, 2023 14:00
@timfish timfish merged commit 3064e99 into getsentry:master Jul 13, 2023
@timfish timfish deleted the fix/normalise-module branch September 28, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Electron - For the module field, exclude anything before .asar/

2 participants