feat: Update JavaScript SDKs to v8.48.0#1046
Conversation
|
@timfish sounds like this is the PR that will allow ANR events to symbolicate? Would a client on SDK v5.9.0 need to make any changes on their side? Or will it work once this is merged? Thanks for all you've done! |
|
This needs to be merged and then this will be released in v5.10.0 |
| # we want that the matrix keeps running, default is to cancel all if one fails. | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] |
There was a problem hiding this comment.
ubuntu-latest changed to Ubuntu 24 in the last week and all the Linux tests started failing due to sandbox issues:
https://github.com/getsentry/sentry-electron/actions/runs/12652009781
The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /home/runner/work/sentry-electron/sentry-electron/.cache/30.5.1-x64/chrome-sandbox is owned by root and has mode 4755.
We already had to disable the sandbox for older versions of Electron but something has changed in the latest Github Actions images
sentry-electron/test/e2e/context.ts
Lines 75 to 77 in 976b580
We cannot disable the sandbox entirely on Linux because we need to test it's functionality!
I need to find a way to fix this but it's not important for this PR
|
For some reason CI is reporting: 
But they have clearly completed sucessfully: https://github.com/getsentry/sentry-electron/actions/runs/12669658435/job/35307658102?pr=1046 |
|
I updated branch protection to require ubuntu-22.04 instead of ubuntu-latest! |
Updates JavaScript SDKs to v8.48.0.
The Node SDK has a fix for ANR debug IDs so this PR also includes test changes to confirm this.