Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #846 +/- ##
==========================================
- Coverage 80.97% 80.96% -0.02%
==========================================
Files 177 177
Lines 5615 5621 +6
Branches 1408 1409 +1
==========================================
+ Hits 4547 4551 +4
- Misses 649 650 +1
- Partials 419 420 +1
Continue to review full report at Codecov.
|
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
- We need to add this to the docs.
- This is a breaking change technically. Since users before were using a different field to set this value. We need to add a note on the release notes.
- Tests are flaky
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Contributor
Author
|
@bruno-garcia mention the breaking change in the changelog? or in docs? |
bruno-garcia
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #736