Skip to content

Add net9.0 support#3699

Merged
jamescrosswell merged 37 commits intoversion-5.0.0from
net9
Nov 3, 2024
Merged

Add net9.0 support#3699
jamescrosswell merged 37 commits intoversion-5.0.0from
net9

Conversation

@jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Oct 22, 2024

Fixes #3484 (comment)

Notes for Reviewers

Mostly just a version bump, but with various domino effects:

  • We started running out of space on our runners, so includes various workarounds to free up disk space on ubuntu and macos
  • The analysers in net9.0 raised various new vulnerability warnings that had to be dealt with either by bumping dependencies or ignoring warnings
  • Had to work around some contention issues with LocalDb

Device Tests

  • When targeting net8.0-android, trimming has to be disabled. We had it enabled implicitly by setting IsAotCompatible = true for net8.0+ when FrameworkSupportsAot == true. That property has been renamed to EnableAot and we now override this and set it to false when running the android device tests.
  • To get the iOS device tests running on arm, an x64 runtime identifier had to be used
  • To get the iOS device tests to run against net8.0-ios, the interpreter has to be enabled explicitly (presumably the default for this was changed between net7.0-ios and net8.0-ios
  • Disabled some flaky tests

@jamescrosswell jamescrosswell marked this pull request as ready for review October 31, 2024 07:50
Copy link
Contributor

@bricefriha bricefriha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing stuff James, thank you!


## Unreleased
### Features
- Added support for `.NET 9` (preview) ([#3699](https://github.com/getsentry/sentry-dotnet/pull/3699))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Added support for `.NET 9` (preview) ([#3699](https://github.com/getsentry/sentry-dotnet/pull/3699))
- Added support for `.NET 9` (preview) ([#3699](https://github.com/getsentry/sentry-dotnet/pull/3699))

<NoWarn>$(NoWarn);CS8002</NoWarn>

<!-- We need to support old stuff. Applications should definitely address these advisory warnings though. -->
<NoWarn>$(NoWarn);NU1903</NoWarn>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a major, it's a good time to review the lowest we support and bump some a bit (not necessarily to latest)

@jamescrosswell jamescrosswell merged commit cdbec91 into version-5.0.0 Nov 3, 2024
@jamescrosswell jamescrosswell deleted the net9 branch November 3, 2024 10:46
@bruno-garcia bruno-garcia mentioned this pull request May 7, 2025
5 tasks
@bitsandfoxes bitsandfoxes mentioned this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants