Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jun 14, 2023

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Fixed flutter/flutter#73652 for Flutter 3.3.0 and above.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

@marandaneto marandaneto requested a review from a team as a code owner June 14, 2023 10:09
@vercel
Copy link

vercel bot commented Jun 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 11:46am

Copy link
Contributor

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Small wording suggestion

Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
@marandaneto marandaneto enabled auto-merge (squash) June 14, 2023 11:39
@marandaneto marandaneto merged commit 652b0b9 into master Jun 14, 2023
@marandaneto marandaneto deleted the chore/flutter-windows-version branch June 14, 2023 11:49
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows] support pubspec.yaml version/build number in windows projects

3 participants