Skip to content

Remove references to @sentry/tracing for node performance#6523

Merged
AbhiPrasad merged 1 commit intogetsentry:masterfrom
timfish:tracing/node
Mar 30, 2023
Merged

Remove references to @sentry/tracing for node performance#6523
AbhiPrasad merged 1 commit intogetsentry:masterfrom
timfish:tracing/node

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented Mar 23, 2023 •
edited
Loading

ref getsentry/sentry-javascript#5815 and #6518

This PR updates our instructions to remove the dependency on using the @sentry/tracing package for the node.js SDK and its derivatives. The node.js SDK now enables tracing support by default and the tracing integrations are now available on the Integrations namespace.

Before:

import * as Sentry from '@sentry/node';
import '@sentry/tracing';

Sentry.init({
  dsn: '__DSN__',
  tracesSampleRate: 1.0,
});
import * as Sentry from '@sentry/node';
import * as Tracing from '@sentry/tracing';

Sentry.init({
  dsn: '__DSN__',
  tracesSampleRate: 1.0,
  integrations: [new Tracing.Integrations.Postgres()],
});

After:

import * as Sentry from '@sentry/node';

Sentry.init({
  dsn: '__DSN__',
  tracesSampleRate: 1.0,
  integrations: [...Sentry.autoDiscoverNodePerformanceMonitoringIntegrations()],
});
import * as Sentry from '@sentry/node';

Sentry.init({
  dsn: '__DSN__',
  tracesSampleRate: 1.0,
  integrations: [new Sentry.Integrations.Postgres()],
});

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 23, 2023

@timfish is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@timfish timfish marked this pull request as ready for review March 23, 2023 18:53
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 29, 2023
Closed
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 29, 2023 at 9:21AM (UTC)

@AbhiPrasad AbhiPrasad requested a review from lizokm March 29, 2023 09:04
@AbhiPrasad
Copy link
Copy Markdown
Contributor

AbhiPrasad commented Mar 30, 2023

cc @JonasBa - we removed the tracing package requirement!

@AbhiPrasad AbhiPrasad merged commit 1bc4bd8 into getsentry:master Mar 30, 2023
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 30, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2023
@timfish timfish deleted the tracing/node branch September 29, 2023 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lizokm lizokm Awaiting requested review from lizokm

1 more reviewer

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timfish @AbhiPrasad