Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| replay.stop(); // Stop recording | ||
| ``` | ||
|
|
||
| ## General Integration Configuration |
There was a problem hiding this comment.
Starting with the sampling options, which are the main ones/everyone will use
| | inlineStylesheet | boolean | `true` | Should inline stylesheets used in the recording | | ||
| | recordCanvas | boolean | `false` | Should record `<canvas>` elements | | ||
|
|
||
| ## Identifying Users |
There was a problem hiding this comment.
Identifying user is an SDK specific thing. It'll improve the user experience for sure, so makes total sense to add here. I tried to word it a bit as "here are the actual docs, but here's a quick snippet to get you started"
| }); | ||
| ``` | ||
|
|
||
| ## Start and Stop Recording Manually |
There was a problem hiding this comment.
I'm assuming here we prefer users keep with defaults and let the SDK start/stop. Is that valid? For that reason, moving to the bottom.
These APIs can become a source of support issues, where the SDK is already start/stopping but users decide to call it too and then are confused by the duration of replays. For that reason, if debug=true and start() is called but there's already a replay running, worth logging out, for discoverability sake.
Do we know of some use cases when users want to start/stop manually? Is it worth adding here to the docs "you for example want to xyz"?
| --- | ||
| title: Custom Instrumentation | ||
| sidebar_order: 4100 | ||
| description: "Learn how to set up General and Privacy aware configuration fields." | ||
| --- | ||
|
|
||
| <PageGrid /> |
There was a problem hiding this comment.
Whatever the name is, it's nice to have a single url to capture both sets of configs (and i agree that it's nice to split out privacy configs and give them their own headers)
I had intended to link directly to this page from our in-app onboarding wizard: #5914. So for that reason I think we should keep this page, name changes are fine with me.
|
Thanks @imatwawana 🙏 will take this changes in a follow up PR (target was merged into master) |
|
|
||
| <script | ||
| src="https://browser.sentry-cdn.com/{{ packages.version('sentry.javascript.browser') }}/bundle.min.js" | ||
| integrity="sha384-{{ packages.checksum('sentry.javascript.browser', 'bundle.min.js', 'sha384-base64') }}" |
There was a problem hiding this comment.
drive by review: we should make this the browser + performance bundle so it's easy for folks to use performance monitoring if they want to in the future.
|
Superseded by #5927 |
Alternative structure. Comments inline