Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
20 tasks
lizokm
approved these changes
Oct 21, 2022
Contributor
lizokm
left a comment
There was a problem hiding this comment.
Made a small suggestion, otherwise, this looks great :)
|
|
||
| _Import name: `Sentry.Integrations.RequestData`_ | ||
|
|
||
| This integration adds data from the current incoming request (if any) to events. |
Contributor
There was a problem hiding this comment.
Suggested change
| This integration adds data from the current incoming request (if any) to events. | |
| This integration adds data from an incoming request, (if one is in progress), to events. |
Would like to simplify to just say "incoming request" unless it's commonly expected to call it "current incoming request" :)
Member
Author
There was a problem hiding this comment.
Okay, tried again. LMK what you think.
UPDATE: Given that this feature has now been released, I'm going to go ahead and merge this, and we can always come back to the specific wording later.
0c1a6ab to
79349b0
Compare
AbhiPrasad
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds documentation for the new
RequestDataintegration in the node SDK, which adds request data to events. For frameworks where we don't have wrappers in the SDK, and merely tell people how to use sentry in the docs, this also adds storing the request in scope metadata to our boilerplate.