feat: Add MaxCacheItems to basic options#3308
Merged
philipphofmann merged 3 commits intomasterfrom Mar 25, 2021
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/8XJ9UdwZkxXSyVHcgV4e4btgo8Zr |
marandaneto
reviewed
Mar 24, 2021
marandaneto
reviewed
Mar 24, 2021
|
|
||
| <ConfigKey name="max-cache-items" supported={[ "dotnet", "android"]} > | ||
|
|
||
| The maximum number of [envelopes](https://develop.sentry.dev/sdk/envelopes/) to keep in cache. The SDKs use envelopes to send data, as events, attachments, user feedback, session, etc. to Sentry. An envelope can contain multiple items - for example, an event with a session and two attachments. Depending on the usage of the SDK, the size of an envelope can differ. When the number of envelopes in the local cache exceeds max-cache-items, the SDK deletes the oldest envelope. When deleting an envelope, we migrate sessions to the next envelope to not mess up your release health stats. The default is `30`. |
Contributor
There was a problem hiding this comment.
Suggested change
| The maximum number of [envelopes](https://develop.sentry.dev/sdk/envelopes/) to keep in cache. The SDKs use envelopes to send data, as events, attachments, user feedback, session, etc. to Sentry. An envelope can contain multiple items - for example, an event with a session and two attachments. Depending on the usage of the SDK, the size of an envelope can differ. When the number of envelopes in the local cache exceeds max-cache-items, the SDK deletes the oldest envelope. When deleting an envelope, we migrate sessions to the next envelope to not mess up your release health stats. The default is `30`. | |
| The maximum number of [envelopes](https://develop.sentry.dev/sdk/envelopes/) to keep in cache. The SDKs use envelopes to send data, as events, attachments, user feedback, session, etc. to Sentry. An envelope can contain multiple items - for example, an event with a session and two attachments. Depending on the usage of the SDK, the size of an envelope can differ. When the number of envelopes in the local cache exceeds max-cache-items, the SDK deletes the oldest envelope. The default is `30`. |
I think this is implementation details, if we want to explain it, it'd be better to release health docs
Member
Author
There was a problem hiding this comment.
I added it because people might think that this messes up their session stats. Just wanted to clarify that this is not affected. @bruno-garcia, what do you think? Should we keep it or remove it?
marandaneto
reviewed
Mar 24, 2021
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
PeloWriter
approved these changes
Mar 24, 2021
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are going to enable Apple once 7.0.0 GA is released. I added this to #3307 to not forget about it.
Fixes GH-2879