Skip to content

feat(apple): Enable sendDefaultPii#2983

Merged
philipphofmann merged 1 commit intomasterfrom
feat/apple-default-pii
Feb 22, 2021
Merged

feat(apple): Enable sendDefaultPii#2983
philipphofmann merged 1 commit intomasterfrom
feat/apple-default-pii

Conversation

@philipphofmann
Copy link
Copy Markdown
Member

We added this for Apple recently, see
getsentry/sentry-cocoa#923.

Only merge when sentry-cocoa 6.1.5 is released.

We added this for Apple recently, see
getsentry/sentry-cocoa#923.
@philipphofmann philipphofmann requested a review from a team February 1, 2021 10:14
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/3aqkrsh1s/sentry.dev
✅ Preview: https://sentry-docs-git-feat-apple-default-pii.sentry.dev

</ConfigKey>

<ConfigKey name="send-default-pii" supported={["dotnet", "javascript", "node", "react-native", "python", "java", "php", "rust"]}>
<ConfigKey name="send-default-pii" supported={["apple", "dotnet", "javascript", "node", "react-native", "python", "java", "php", "rust"]}>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this PR but:
we'd need to go thru all the options (options.mdx) and check 1 by 1 for each mobile platform, I suspect a few of them are missing, I don't recall adding new options here often but I do recall adding on code :P

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2985 so we don't forget

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@philipphofmann philipphofmann merged commit 76493fe into master Feb 22, 2021
@philipphofmann philipphofmann deleted the feat/apple-default-pii branch February 22, 2021 15:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants