ref(node): Clarify usage of onFatalError option in node#2643
Merged
kamilogorek merged 3 commits intomasterfrom Nov 3, 2020
Merged
ref(node): Clarify usage of onFatalError option in node#2643kamilogorek merged 3 commits intomasterfrom
kamilogorek merged 3 commits intomasterfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/4f8qrqzbe/sentry.dev |
9 tasks
lobsterkatie
reviewed
Nov 2, 2020
src/platforms/node/common/configuration/integrations/default-integrations.mdx
Outdated
Show resolved
Hide resolved
lobsterkatie
reviewed
Nov 2, 2020
src/platforms/node/common/configuration/integrations/default-integrations.mdx
Outdated
Show resolved
Hide resolved
MimiDumpling
approved these changes
Nov 2, 2020
|
|
||
| <Alert level="warning" title="Note"> | ||
|
|
||
| Be aware that if you are overwriting this setting, you will lose the default implementation, which handles draining queued events before exiting. If you want to see how it works and recreates in your custom code, see the implementation of [`logAndExitProcess`](https://github.com/getsentry/sentry-javascript/blob/master/packages/node/src/handlers.ts) function. |
Contributor
There was a problem hiding this comment.
Suggested change
| Be aware that if you are overwriting this setting, you will lose the default implementation, which handles draining queued events before exiting. If you want to see how it works and recreates in your custom code, see the implementation of [`logAndExitProcess`](https://github.com/getsentry/sentry-javascript/blob/master/packages/node/src/handlers.ts) function. | |
| Be aware that if you are overwriting this setting, you will lose the default implementation, which handles draining queued events before exiting. If you want to examine how it works and then recreate it in your code, see the implementation of the [`logAndExitProcess`](https://github.com/getsentry/sentry-javascript/blob/master/packages/node/src/handlers.ts) function. |
Co-authored-by: Katie Byers <katie.byers@sentry.io>
kamilogorek
commented
Nov 3, 2020
src/platforms/node/common/configuration/integrations/default-integrations.mdx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Applied both suggestions. Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes getsentry/sentry-javascript#1661 (comment)
Fixes getsentry/sentry-javascript#2796 (comment)