docs(caches): Add cache.write and cache.operation to span data spec#17022
Merged
docs(caches): Add cache.write and cache.operation to span data spec#17022
Conversation
Add cache.write (bool) to the required span data table — indicates whether a write-operation actually modified the cache, reflecting the actual outcome for conditional operations like putIfAbsent and replace. Add cache.operation (string) as an optional attribute for SDKs that use granular span operations beyond the four base ops. Fix typo: "sepreated" → "separated" in span description section. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8 tasks
Expand cache attributes in span data conventions to match the\ncache module guidance in this PR.\n\nDocument operation, write outcome, success, TTL, and cache peer\nnetwork attributes so SDK teams can implement consistent span data. Co-Authored-By: Claude <noreply@anthropic.com>
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
cache.writeandcache.operationto the Caches module span data spec, and clarify that span operations should use the real method name.cache.writeindicates whether a cache operation resulted in a write to the cache. It reflects the actual outcome for conditional operations (e.g.putIfAbsent,replace) and is alwaystruefor unconditional writes. This is now set by the sentry-java SDK across its Spring Cache and JCache integrations.cache.operationcaptures the specific cache method name, which is useful when SDKs use more granular span operations than the four base ops defined here.The span operations section now notes that
cache.<methodName>is the intended format, with the table serving as common examples rather than an exhaustive list.Also fixes a typo: "sepreated" → "separated".