Instruct to use the recommended way of using Vue component tracking#11917
Merged
Instruct to use the recommended way of using Vue component tracking#11917
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
5 tasks
Bundle ReportChanges will increase total bundle size by 95.28kB (0.48%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Lms24
approved these changes
Nov 22, 2024
| ``` | ||
|
|
||
| The following hooks are available to track in Vue 3: `['activate', 'create', 'unmount', 'mount', 'update']` | ||
| The default set of tracked hooks is `['activate', 'mount', 'update']`. |
Member
There was a problem hiding this comment.
There's another item in the v9 list to remove update as a hook to track by default, right? No action required, was just remembering that we discussed this
| The following hooks are available to track in Vue 3: `['activate', 'create', 'unmount', 'mount', 'update']` | ||
|
|
||
| Note, that when specifying `hooks`, we use the simple verb rather than `before` and `-ed` pairs. For example, `unmount` is correct, while `beforeUnmount` and `unmounted` are incorrect. | ||
| The following hooks are available to track: `['activate', 'create', 'unmount', 'mount', 'update']` |
Member
There was a problem hiding this comment.
l: Iet's also add the hooks tracked by default here
added 2 commits
November 25, 2024 09:26
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Based on getsentry/sentry-javascript#14265 and getsentry/sentry-javascript#14385 we are updating how users should enable component tracking for Vue and Nuxt.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.