Skip to content

feat(python): Add failed_request_status_codes to integrations #10282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sentrivana merged 1 commit into from
Jun 6, 2024
Merged

feat(python): Add failed_request_status_codes to integrations #10282

sentrivana merged 1 commit into from
Jun 6, 2024

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jun 5, 2024 •
edited
Loading

DESCRIBE YOUR PR

Adding a new option to the Starlette and FastAPI integrations to configure the status code to create events on in getsentry/sentry-python#3008.

Direct links to preview:

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 10:01am

@sentrivana sentrivana mentioned this pull request Jun 5, 2024
Merged
@codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 12 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.45MB 3 bytes ⬇️
sentry-docs-edge-server 462.26kB 3 bytes ⬇️
sentry-docs-client 6.19MB 6 bytes ⬇️

@sentrivana sentrivana marked this pull request as ready for review June 5, 2024 10:06
@sentrivana sentrivana self-assigned this Jun 5, 2024
antonpirker
antonpirker approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sentrivana sentrivana merged commit 1a969b6 into master Jun 6, 2024
@sentrivana sentrivana deleted the ivana/python-failed-request-status-codes branch June 6, 2024 11:22
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szokeasaurusrex szokeasaurusrex Awaiting requested review from szokeasaurusrex

2 more reviewers

@antonpirker antonpirker antonpirker approved these changes

@vivianyentran vivianyentran vivianyentran approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sentrivana sentrivana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sentrivana @antonpirker @vivianyentran