Move TelemetryProcessor from span-first branch and replace LogBatcher
#3448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove addSpan method from TelemetryProcessor interface - Remove span buffer from DefaultTelemetryProcessor - Remove captureSpan method from SentryClient - Remove traceLifecycle property from SentryOptions - Remove span imports and exports - Update mocks to remove span-related code Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
packages/dart/lib/src/telemetry/processing/processor_integration.dart
Outdated
Show resolved
Hide resolved
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f872f8e | 402.38 ms | 416.20 ms | 13.82 ms |
| ebccb5b | 363.79 ms | 371.10 ms | 7.31 ms |
| 75284dc | 512.39 ms | 530.87 ms | 18.48 ms |
| 2b5e090 | 437.21 ms | 467.14 ms | 29.93 ms |
| 32914d8 | 461.96 ms | 495.47 ms | 33.51 ms |
| d0aa4b6 | 395.66 ms | 393.13 ms | -2.53 ms |
| 51520fc | 351.89 ms | 349.79 ms | -2.10 ms |
| 114239b | 423.44 ms | 426.57 ms | 3.13 ms |
| 6e7d494 | 397.35 ms | 378.91 ms | -18.43 ms |
| 73dca78 | 476.53 ms | 522.21 ms | 45.68 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f872f8e | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| ebccb5b | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| 75284dc | 13.93 MiB | 14.93 MiB | 1.00 MiB |
| 2b5e090 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
| 32914d8 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| d0aa4b6 | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| 51520fc | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| 114239b | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| 6e7d494 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
| 73dca78 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
Previous results on branch: feat/telemetry-processor
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6da49c8 | 383.67 ms | 386.40 ms | 2.73 ms |
| 3ca4c08 | 368.93 ms | 354.40 ms | -14.53 ms |
| 82a4374 | 577.33 ms | 579.52 ms | 2.20 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6da49c8 | 14.09 MiB | 15.28 MiB | 1.19 MiB |
| 3ca4c08 | 14.09 MiB | 15.28 MiB | 1.19 MiB |
| 82a4374 | 14.09 MiB | 15.28 MiB | 1.19 MiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c0dde50 | 1268.90 ms | 1275.61 ms | 6.71 ms |
| ebccb5b | 1245.39 ms | 1249.31 ms | 3.92 ms |
| ea06d23 | 1254.02 ms | 1252.60 ms | -1.42 ms |
| 0fb3800 | 1256.60 ms | 1266.28 ms | 9.68 ms |
| 6ad8fc4 | 1263.70 ms | 1266.06 ms | 2.36 ms |
| bbdbcb9 | 1262.70 ms | 1261.86 ms | -0.84 ms |
| e5ae2a6 | 1240.48 ms | 1253.26 ms | 12.78 ms |
| d3fb366 | 1258.29 ms | 1260.79 ms | 2.51 ms |
| 7cfee3b | 1260.90 ms | 1273.14 ms | 12.24 ms |
| 765aa8b | 1259.09 ms | 1269.90 ms | 10.82 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c0dde50 | 5.53 MiB | 6.01 MiB | 488.14 KiB |
| ebccb5b | 5.53 MiB | 5.96 MiB | 444.86 KiB |
| ea06d23 | 5.53 MiB | 5.96 MiB | 443.26 KiB |
| 0fb3800 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 6ad8fc4 | 5.53 MiB | 6.01 MiB | 487.65 KiB |
| bbdbcb9 | 5.53 MiB | 6.02 MiB | 501.33 KiB |
| e5ae2a6 | 5.65 MiB | 6.09 MiB | 446.96 KiB |
| d3fb366 | 5.53 MiB | 6.01 MiB | 487.96 KiB |
| 7cfee3b | 20.70 MiB | 22.46 MiB | 1.75 MiB |
| 765aa8b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
TelemetryProcessor from span-first branch and replace LogBatcher
denrase
approved these changes
Jan 15, 2026
Collaborator
denrase
left a comment
There was a problem hiding this comment.
Lookin good, just one suggestion.
Collaborator
|
We also need to check why some CI checks are red. |
Contributor
Author
|
@denrase double checked and red CI is unrelated to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No implementations added, only removed things that dont exist yet in the main branch which is the new span model
this allows us to work on metrics sooner