Change SDK name of Sentry Native for Flutter#1468
Merged
marandaneto merged 3 commits intomainfrom May 23, 2023
Merged
Conversation
marandaneto
reviewed
May 22, 2023
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
May 22, 2023
Collaborator
Author
|
@marandaneto I tried to check the SDK names on sentry.io through the example app, but i'm not seeing those values set, neither for iOS nor Android. Am I looking in the wrong place? 
|
Contributor
The place is right, but events captured on the Dart layer will be this name. When this method is executed SDK name should be sentry.java.android.flutter (it is already).
When those 2 methods are called SDK name it should be called sentry.native.android.flutter -> this is the one that needs fixing.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
==========================================
+ Coverage 90.22% 91.35% +1.13%
==========================================
Files 181 160 -21
Lines 5798 5148 -650
==========================================
- Hits 5231 4703 -528
+ Misses 567 445 -122 ☔ View full report in Codecov by Sentry. |
Contributor
marandaneto
approved these changes
May 23, 2023
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bf4aed7 | 311.24 ms | 365.66 ms | 54.42 ms |
| 0be962b | 325.54 ms | 382.83 ms | 57.29 ms |
| 8fa3934 | 340.64 ms | 407.92 ms | 67.28 ms |
| e66e71e | 296.84 ms | 345.43 ms | 48.59 ms |
| ef2f368 | 350.06 ms | 429.44 ms | 79.38 ms |
| 62dde43 | 339.21 ms | 423.06 ms | 83.85 ms |
| a094100 | 388.02 ms | 459.50 ms | 71.48 ms |
| b2cbbc8 | 347.80 ms | 395.31 ms | 47.51 ms |
| a61674e | 331.35 ms | 391.06 ms | 59.71 ms |
| 0a82a1e | 321.02 ms | 393.82 ms | 72.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bf4aed7 | 6.06 MiB | 7.03 MiB | 997.04 KiB |
| 0be962b | 6.06 MiB | 7.03 MiB | 990.29 KiB |
| 8fa3934 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| e66e71e | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| ef2f368 | 5.94 MiB | 6.89 MiB | 975.81 KiB |
| 62dde43 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| a094100 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| b2cbbc8 | 6.06 MiB | 7.03 MiB | 995.45 KiB |
| a61674e | 6.06 MiB | 7.03 MiB | 990.29 KiB |
| 0a82a1e | 6.15 MiB | 7.11 MiB | 981.82 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Update SDK names set in native plugins.
💡 Motivation and Context
Closes #1333
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled