linter issues

vaind · vaind · commit b1cd9a37454d · 2024-12-04T10:57:39.000+01:00
diff --git a/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt b/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
@@ -39,6 +39,7 @@ import java.lang.ref.WeakReference
 import kotlin.math.roundToInt
 
 private const val APP_START_MAX_DURATION_MS = 60000
+private const val VIDEO_BLOCK_SIZE = 16
 
 class SentryFlutterPlugin :
   FlutterPlugin,
@@ -576,11 +577,11 @@ class SentryFlutterPlugin :
     }
 
     private fun Double.adjustReplaySizeToBlockSize(): Double {
-      val remainder = this % 16
-      return if (remainder <= 8) {
+      val remainder = this % VIDEO_BLOCK_SIZE
+      return if (remainder <= VIDEO_BLOCK_SIZE / 2) {
         this - remainder
       } else {
-        this + (16 - remainder)
+        this + (VIDEO_BLOCK_SIZE - remainder)
       }
     }
   }
diff --git a/flutter/lib/src/screenshot/sentry_screenshot_widget.dart b/flutter/lib/src/screenshot/sentry_screenshot_widget.dart
@@ -68,10 +68,11 @@ typedef SentryScreenshotWidgetOnBuildCallback = bool Function(
 class _SentryScreenshotWidgetState extends State<SentryScreenshotWidget> {
   @override
   Widget build(BuildContext context) {
+    final mq = MediaQuery.of(context);
     final status = SentryScreenshotWidgetStatus(
-      size: MediaQuery.maybeSizeOf(context),
-      pixelRatio: MediaQuery.maybeDevicePixelRatioOf(context),
-      orientantion: MediaQuery.maybeOrientationOf(context),
+      size: mq.size,
+      pixelRatio: mq.devicePixelRatio,
+      orientantion: mq.orientation,
     );
     final prevStatus = SentryScreenshotWidget._status;
     SentryScreenshotWidget._status = status;
diff --git a/flutter/test/replay/scheduler_test.dart b/flutter/test/replay/scheduler_test.dart
@@ -63,11 +63,11 @@ class _Fixture {
     sut = Scheduler(
       const Duration(milliseconds: 1),
       (_) async => calls++,
-      _AddPostFrameCallbackMock,
+      _addPostFrameCallbackMock,
     );
   }
 
-  void _AddPostFrameCallbackMock(FrameCallback callback,
+  void _addPostFrameCallbackMock(FrameCallback callback,
       {String debugLabel = 'callback'}) {
     registeredCallback = callback;
   }

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@ import java.lang.ref.WeakReference`
`39`	`39`	`import kotlin.math.roundToInt`
`40`	`40`
`41`	`41`	`private const val APP_START_MAX_DURATION_MS = 60000`
	`42`	`+private const val VIDEO_BLOCK_SIZE = 16`
`42`	`43`
`43`	`44`	`class SentryFlutterPlugin :`
`44`	`45`	`FlutterPlugin,`
`@@ -576,11 +577,11 @@ class SentryFlutterPlugin :`
`576`	`577`	`}`
`577`	`578`
`578`	`579`	`private fun Double.adjustReplaySizeToBlockSize(): Double {`
`579`		`- val remainder = this % 16`
`580`		`- return if (remainder <= 8) {`
	`580`	`+ val remainder = this % VIDEO_BLOCK_SIZE`
	`581`	`+ return if (remainder <= VIDEO_BLOCK_SIZE / 2) {`
`581`	`582`	`this - remainder`
`582`	`583`	`} else {`
`583`		`- this + (16 - remainder)`
	`584`	`+ this + (VIDEO_BLOCK_SIZE - remainder)`
`584`	`585`	`}`
`585`	`586`	`}`
`586`	`587`	`}`
Original file line number	Diff line number	Diff line change
`@@ -63,11 +63,11 @@ class _Fixture {`
`63`	`63`	`sut = Scheduler(`
`64`	`64`	`const Duration(milliseconds: 1),`
`65`	`65`	`(_) async => calls++,`
`66`		`- _AddPostFrameCallbackMock,`
	`66`	`+ _addPostFrameCallbackMock,`
`67`	`67`	`);`
`68`	`68`	`}`
`69`	`69`
`70`		`- void _AddPostFrameCallbackMock(FrameCallback callback,`
	`70`	`+ void _addPostFrameCallbackMock(FrameCallback callback,`
`71`	`71`	`{String debugLabel = 'callback'}) {`
`72`	`72`	`registeredCallback = callback;`
`73`	`73`	`}`