Skip to content

Updated some AI attributes#53

Merged
AbhiPrasad merged 1 commit intomainfrom
antonpirker/update-ai-attributes
May 7, 2025
Merged

Updated some AI attributes#53
AbhiPrasad merged 1 commit intomainfrom
antonpirker/update-ai-attributes

Conversation

@antonpirker
Copy link
Contributor

There were ai.total_cost and ai.pipeline.name missing that are both used in relay.

@antonpirker antonpirker requested a review from AbhiPrasad May 7, 2025 11:35
@antonpirker
Copy link
Contributor Author

@AbhiPrasad I have added two attributes to the AI attributes. The ai.total_cost is not sent directly by the SDKs but calculated in relay. Should this be mentioned in the semnatic conventions?

@antonpirker antonpirker marked this pull request as ready for review May 7, 2025 11:36
Copy link
Contributor

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be mentioned in the semnatic conventions

yes for sure, this needs to be an exhaustive list. Thanks for the PR @antonpirker - hope the contributing docs were useful.

@AbhiPrasad AbhiPrasad merged commit 3b059ac into main May 7, 2025
5 checks passed
@AbhiPrasad AbhiPrasad deleted the antonpirker/update-ai-attributes branch May 7, 2025 15:33
@antonpirker
Copy link
Contributor Author

Yes, contributing docs are great! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants