feat(attributes): Add device memory and core count attributes#281
Merged
feat(attributes): Add device memory and core count attributes#281
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Deps
Deps Dev
Other
🤖 This preview updates automatically when you update the PR. |
cleptric
approved these changes
Mar 13, 2026
474ca4b to
fc02293
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds attributes sent from the JS SDK describing device memory and cpu core count properties. As we discussed in Slack, we want to take the opportunity to move the non-existing/suboptimal attribute names over to properly name-spaced attribute names.
hardwareConcurrencydevice.cpu.logical_core_countdevice.exists but not the exact attributedeviceMemorydevice.memory.estimated_capacitydevice.exists but not the exact attributeI checked and none of these attributes are used in dashboard prebuilt configs.
Worth noting:
device.memory.estimated_capacitybecause browsers really only give a rough "bucket" how much memory is available. They cap it at 8GB mostly. Also changed the expected type tointegersince IMHO it makes more sense to query/aggregate on them. We can sendgigabyteas the unit on the attribute.navigator.hardwareConcurrency). This is because browsers report what amount of logical cores they have at their disposal.PR Checklist
yarn testand verified that the tests pass.yarn generate && yarn formatto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)pii(i.e.maybeortrue. Usefalseonly for values that should never be scrubbed such as IDs)If an attribute was deprecated: