Skip to content

chore(attributes): Add legacy attribute definitions for transaction spans#212

Merged
Ahmed-Labs merged 4 commits intomainfrom
ahmedmo/chore/add-legacy-attributes
Dec 18, 2025
Merged

chore(attributes): Add legacy attribute definitions for transaction spans#212
Ahmed-Labs merged 4 commits intomainfrom
ahmedmo/chore/add-legacy-attributes

Conversation

@Ahmed-Labs
Copy link
Contributor

@Ahmed-Labs Ahmed-Labs commented Dec 18, 2025

Description

Adds some legacy attributes used by transactions spans:

  • sentry.action
  • sentry.domain
  • sentry.group
  • sentry.normalized_description

The motivation is that we'd like to double-write to these attributes within the span first Relay pipeline for backwards compatibility. Aside from that, these are actively used attributes within products and will continue to be relevant due to the inevitable ingestion of legacy spans even in the long term.

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate && yarn format to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I have used the correct value for pii (i.e. maybe or true. Use false only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

Note: it seems that gen_ai.usage.total_cost is removed from docs after code gen because there is no longer an attribute definition for it. Please let me know if this is unexpected.

@Ahmed-Labs Ahmed-Labs changed the title chore(attributes): Add some legacy attribute definitons chore(attributes): Add legacy attribute definitions for transaction spans Dec 18, 2025
@Ahmed-Labs Ahmed-Labs marked this pull request as ready for review December 18, 2025 17:20
@Ahmed-Labs Ahmed-Labs merged commit aa18904 into main Dec 18, 2025
14 checks passed
@Ahmed-Labs Ahmed-Labs deleted the ahmedmo/chore/add-legacy-attributes branch December 18, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants