Skip to content

fix: Rename paths that aren't valid on Windows#176

Merged
lcian merged 6 commits intomainfrom
sebastian/windows-paths
Oct 22, 2025
Merged

fix: Rename paths that aren't valid on Windows#176
lcian merged 6 commits intomainfrom
sebastian/windows-paths

Conversation

@loewenheim
Copy link
Contributor

@loewenheim loewenheim commented Oct 21, 2025

Description

In addition to renaming files containing <,>, this also runs tests on Windows to make sure such invalid names are caught.

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate && yarn format to generate and format code and docs.

#skip-changelog

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!
Hmm I see the build is failing, let me look into that.
Ah alright, it seems that #177 is intended to fix this.

@lcian lcian merged commit 7b0c420 into main Oct 22, 2025
7 of 10 checks passed
@lcian lcian deleted the sebastian/windows-paths branch October 22, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants