feat(sentry): Add sentry.description attribute#135
Merged
loewenheim merged 1 commit intomainfrom Sep 11, 2025
Merged
Conversation
This attribute roughly corresponds to the description field on SpanV1, which is marked as `Pii::Maybe`. If this attribute is not defined in this repo, Relay assumes `Pii::True`.
f67d527 to
91f3a2e
Compare
Member
|
Are we aligned on the naming here? Aka, is this already used in Relay? |
Contributor
|
Should we use |
Contributor
Author
I would leave it as it is analogously to
It's used in the span v2 -> span v1 conversion to populate the |
cleptric
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attribute roughly corresponds to the
descriptionfield on SpanV1, which is marked asPii::Maybe. If this attribute is not defined in this repo, Relay assumesPii::True.Implements INGEST-571.