feat(ai): Add gen_ai_cost_total_tokens field and deprecate old version#126
feat(ai): Add gen_ai_cost_total_tokens field and deprecate old version#126vgrozdanic merged 3 commits intomainfrom
Conversation
| * | ||
| * Attribute defined in OTEL: No | ||
| * | ||
| * @deprecated Use {@link GEN_AI_COST_TOTAL_TOKENS} (gen_ai.cost.total_tokens) instead |
There was a problem hiding this comment.
Should the associated type GEN_AI_USAGE_TOTAL_COST_TYPE also be marked as deprecated?
There was a problem hiding this comment.
Good point, we should also mark the associated types as deprecated during code generation.
There was a problem hiding this comment.
I have only changed json file, everything else was generated
There was a problem hiding this comment.
@lcian is that something that needs to be changed in the generation script, or in this PR?
Even if i change it now, and someone re-generates attributes.ts, that will be overwritten, right?
There was a problem hiding this comment.
Yep the logic needs to be changed in the generation script.
You should only touch the JSONs inside model/, everything else is generated.
Co-authored-by: Lorenzo Cian <lorenzo.cian@sentry.io>
Introduce
gen_ai_cost_total_tokensand double write total tokens cost to it and togen_ai_usage_total_costfor the next 90 days (until the data expires).After that the plan is to completely deprecate
gen_ai_usage_total_costfield to have all the cost related fields undergen_ai.cost.*.Part of TET-1100: Update relay and conventions to reduce work scattering