Conversation
`<` and `>` aren't allowed in file names on Windows, which means this repo can't be checked out there. This replaces those characters with `[` and `]` respectively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test to ensure aliases are symmetric.
Adds 2 more tests to ensure an attribute cannot be marked as replacement/alias of itself.
Addresses the inconsistencies found by the tests as follows:
client.address,http.host,server.addressclient.addressfrom the list of aliases ofhttp.host, otherwiseclient.addresswould need to be an alias forserver.address, which makes no sense.http.hostis deprecated in favor ofserver.address, andclient.addresswill still exist as a separate concept.For the remaining groups, I've added missing aliases and verified the aliases/deprecations are correct wrt OTEL.
List of groups where I added the missing aliases:
http.url,url,url.fullhttp.server_name,net.host.name,server.address:net.host.ip,net.sock.host.addr,network.local.addresshttp.flavor,net.protocol.version,network.protocol.versionnet.peer.ip,network.peer.addressCloses #48